Skip to content

Conversation

@zimbres
Copy link
Contributor

@zimbres zimbres commented Feb 6, 2022

Since ssh-rsa has been deprecated since OpenSSH 8.2 but some git server are still using it like Azure DevOps, its necessary to bring back this feature.

Besisdes, since for internal networks, some people use not have too much concern about deprecated algorithms, this PR can give then hability to change the ssh client and make it compatible with their systems.

configMap example:

apiVersion: v1
kind: ConfigMap
metadata:
  name: argocd-image-updater-ssh-config
  namespace: argocd
data:
  config: |
    Host *
          PubkeyAcceptedAlgorithms +ssh-rsa
          HostkeyAlgorithms +ssh-rsa

This will be loaded in /app/.ssh/config as default user home path in image.

@CLAassistant
Copy link

CLAassistant commented Feb 6, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you @zimbres !

@jannfis jannfis merged commit 295d5c3 into argoproj-labs:master Mar 12, 2022
sribiere-jellysmack pushed a commit to sribiere-jellysmack/argocd-image-updater that referenced this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants